test(release): build assertion status explicitly instead of reading it from a condition #12

Merged

Cody Bryant merged 2 commits from fix/unbreak-the-shell-test-lint into main 2026-08-29 11:21:08 -07:00

Conversation 0 Commits 2 Files changed 2 +24 -5

Cody Bryant commented 2026-08-29 11:02:33 -07:00

Owner

Copy link

$? taken directly after a [ ]/[[ ]] is the condition's status, which shellcheck flags as SC2319 and which any command inserted before the read would silently replace. Builds rc explicitly instead.

This is what has been failing the Shell scripts job on main, so it blocks #10 and #11.

`$?` taken directly after a `[ ]`/`[[ ]]` is the condition's status, which shellcheck flags as SC2319 and which any command inserted before the read would silently replace. Builds `rc` explicitly instead. This is what has been failing the Shell scripts job on main, so it blocks #10 and #11.

Cody Bryant added 2 commits 2026-08-29 11:02:33 -07:00

docs(variance): record why only the MAC half of the privacy guard converges df7c25f25e

test(release): build assertion status explicitly instead of reading it from a condition c1f438d8bd

Cody Bryant merged commit 4e620c2c59 into main 2026-08-29 11:21:08 -07:00

Cody Bryant referenced this pull request from a commit 2026-08-29 11:21:09 -07:00

Merge pull request 'test(release): build assertion status explicitly instead of reading it from a condition' (#12) from fix/unbreak-the-shell-test-lint into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

SisyphusMD/project-standard!12

No description provided.